afiqzudinhadi/obsidian-media-db-sync
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor suggester code

Browse source
This commit is contained in:
Moritz Jung 2025-12-02 12:57:46 +01:00
parent e1a08e0680
commit 4c7ae08f91
2 changed files with 8 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/settings/suggesters/FileSuggest.ts
View file

@ -1,20 +1,13 @@
import type { TAbstractFile } from 'obsidian';
import { AbstractInputSuggest, TFile } from 'obsidian'; import { AbstractInputSuggest, TFile } from 'obsidian';
export class FileSuggest extends AbstractInputSuggest<TFile> { export class FileSuggest extends AbstractInputSuggest<TFile> {
protected getSuggestions(query: string): TFile[] | Promise<TFile[]> { protected getSuggestions(query: string): TFile[] | Promise<TFile[]> {
const abstractFiles = this.app.vault.getAllLoadedFiles();
const files: TFile[] = [];
const lowerCaseInputStr = query.toLowerCase(); const lowerCaseInputStr = query.toLowerCase();
abstractFiles.forEach((file: TAbstractFile) => { // we do two filters because otherwise TS type inference does convert the array to TFile[]
// Match against full path instead of just name return this.app.vault.getAllLoadedFiles()
if (file instanceof TFile && file.path.toLowerCase().contains(lowerCaseInputStr)) { .filter(file => file instanceof TFile)
files.push(file); .filter(file => file.path.toLowerCase().contains(lowerCaseInputStr));
}
});
return files;
} }
renderSuggestion(value: TFile, el: HTMLElement): void { renderSuggestion(value: TFile, el: HTMLElement): void {

14
src/settings/suggesters/FolderSuggest.ts
View file

@ -1,19 +1,13 @@
import type { TAbstractFile } from 'obsidian';
import { AbstractInputSuggest, TFolder } from 'obsidian'; import { AbstractInputSuggest, TFolder } from 'obsidian';
export class FolderSuggest extends AbstractInputSuggest<TFolder> { export class FolderSuggest extends AbstractInputSuggest<TFolder> {
protected getSuggestions(query: string): TFolder[] | Promise<TFolder[]> { protected getSuggestions(query: string): TFolder[] | Promise<TFolder[]> {
const abstractFiles = this.app.vault.getAllLoadedFiles();
const folders: TFolder[] = [];
const lowerCaseInputStr = query.toLowerCase(); const lowerCaseInputStr = query.toLowerCase();
abstractFiles.forEach((folder: TAbstractFile) => { // we do two filters because otherwise TS type inference does convert the array to TFolder[]
if (folder instanceof TFolder && folder.path.toLowerCase().contains(lowerCaseInputStr)) { return this.app.vault.getAllLoadedFiles()
folders.push(folder); .filter(file => file instanceof TFolder)
} .filter(file => file.path.toLowerCase().contains(lowerCaseInputStr));
});
return folders;
} }
renderSuggestion(value: TFolder, el: HTMLElement): void { renderSuggestion(value: TFolder, el: HTMLElement): void {