From c4b5908e6e31116a89d38fdb0e64dc63161b86e0 Mon Sep 17 00:00:00 2001
From: ltctceplrm <14954927+ltctceplrm@users.noreply.github.com>
Date: Wed, 17 Jun 2026 00:03:24 +0200
Subject: [PATCH] Change isbns to strings

---
 packages/obsidian/src/api/apis/OpenLibraryAPI.ts | 12 ++++++------
 packages/obsidian/src/models/BookModel.ts        |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/packages/obsidian/src/api/apis/OpenLibraryAPI.ts b/packages/obsidian/src/api/apis/OpenLibraryAPI.ts
index 32ce14c..742a62b 100644
--- a/packages/obsidian/src/api/apis/OpenLibraryAPI.ts
+++ b/packages/obsidian/src/api/apis/OpenLibraryAPI.ts
@@ -184,8 +184,8 @@ export class OpenLibraryAPI extends APIModel {
 					genres: result.subject,
 					pages: result.number_of_pages_median ?? result.number_of_pages,
 					onlineRating: result.ratings_average,
-					isbn: isbn10 ? Number(isbn10) : undefined,
-					isbn13: isbn13 ? Number(isbn13) : undefined,
+					isbn: isbn10,
+					isbn13: isbn13,
 					image: result.cover_i ? `https://covers.openlibrary.org/b/id/${result.cover_i}-L.jpg` : undefined,
 					released: true,
 					userData: {
@@ -255,8 +255,8 @@ export class OpenLibraryAPI extends APIModel {
 				dataSource: this.apiName,
 				url: `https://openlibrary.org${bookKey}`,
 				id: bookKey,
-				isbn: bookIsbn10 ? Number(bookIsbn10) : searchIsbn10 ? Number(searchIsbn10) : undefined,
-				isbn13: bookIsbn13 ? Number(bookIsbn13) : searchIsbn13 ? Number(searchIsbn13) : undefined,
+				isbn: bookIsbn10 ?? searchIsbn10,
+				isbn13: bookIsbn13 ?? searchIsbn13,
 				author: search?.author_name?.join(', '),
 				plot: this.pickDescription(search?.description),
 				genres: search?.subject,
@@ -328,8 +328,8 @@ export class OpenLibraryAPI extends APIModel {
 				dataSource: this.apiName,
 				id: result.key ?? query,
 				url: result.key ? `https://openlibrary.org${result.key}` : undefined,
-				isbn: isbn10 ? Number(isbn10) : undefined,
-				isbn13: isbn13 ? Number(isbn13) : undefined,
+				isbn: isbn10,
+				isbn13: isbn13,
 				author: result.author_name?.join(', '),
 				plot: this.pickDescription(result.description),
 				genres: result.subject,
diff --git a/packages/obsidian/src/models/BookModel.ts b/packages/obsidian/src/models/BookModel.ts
index 7d0aba7..abf990b 100644
--- a/packages/obsidian/src/models/BookModel.ts
+++ b/packages/obsidian/src/models/BookModel.ts
@@ -12,8 +12,8 @@ export class BookModel extends MediaTypeModel {
 	pages: number;
 	image: string;
 	onlineRating: number;
-	isbn: number;
-	isbn13: number;
+	isbn: string;
+	isbn13: string;
 
 	released: boolean;
 
@@ -32,8 +32,8 @@ export class BookModel extends MediaTypeModel {
 		this.pages = 0;
 		this.image = '';
 		this.onlineRating = 0;
-		this.isbn = 0;
-		this.isbn13 = 0;
+		this.isbn = '';
+		this.isbn13 = '';
 
 		this.released = false;