fix issue

tests/media-type-manager.test.ts

@@ -0,0 +1,62 @@
+import { expect, test } from 'bun:test';
+import { MovieModel } from 'packages/obsidian/src/models/MovieModel';
+import type { MediaDbPluginSettings } from 'packages/obsidian/src/settings/Settings';
+import { MediaTypeManager } from 'packages/obsidian/src/utils/MediaTypeManager';
+
+function createSettings(overrides: Partial<MediaDbPluginSettings> = {}): MediaDbPluginSettings {
+	return {
+		movieFileNameTemplate: '{{ title }} ({{ year }})',
+		seriesFileNameTemplate: '',
+		seasonFileNameTemplate: '',
+		mangaFileNameTemplate: '',
+		gameFileNameTemplate: '',
+		wikiFileNameTemplate: '',
+		musicReleaseFileNameTemplate: '',
+		boardgameFileNameTemplate: '',
+		bookFileNameTemplate: '',
+		movieTemplate: '',
+		seriesTemplate: '',
+		seasonTemplate: '',
+		mangaTemplate: '',
+		gameTemplate: '',
+		wikiTemplate: '',
+		musicReleaseTemplate: '',
+		boardgameTemplate: '',
+		bookTemplate: '',
+		...overrides,
+	} as MediaDbPluginSettings;
+}
+
+test('getFileName falls back to title when templates have not been initialized', () => {
+	const manager = new MediaTypeManager();
+	const movie = new MovieModel({ title: 'Arrival', year: '2016' });
+
+	expect(manager.getFileName(movie)).toBe('Arrival');
+});
+
+test('getFileName uses the configured template for the media type', () => {
+	const manager = new MediaTypeManager();
+	const movie = new MovieModel({ title: 'Arrival', year: '2016' });
+
+	manager.updateTemplates(createSettings({ movieFileNameTemplate: '{{ title }} - {{ year }}' }));
+
+	expect(manager.getFileName(movie)).toBe('Arrival - 2016');
+});
+
+test('getFileName omits undefined template values', () => {
+	const manager = new MediaTypeManager();
+	const movie = new MovieModel({ title: 'Arrival', year: undefined });
+
+	manager.updateTemplates(createSettings({ movieFileNameTemplate: '{{ title }} {{ missingField }} {{ year }}' }));
+
+	expect(manager.getFileName(movie)).toBe('Arrival ');
+});
+
+test('getFileName sanitizes illegal filename characters and duplicate spaces', () => {
+	const manager = new MediaTypeManager();
+	const movie = new MovieModel({ title: 'Star: Trek /  First <Contact>', year: '1996' });
+
+	manager.updateTemplates(createSettings({ movieFileNameTemplate: '{{ title }}   {{ year }}' }));
+
+	expect(manager.getFileName(movie)).toBe('Star - Trek - First Contact 1996');
+});

tests/modal-helper.test.ts

@@ -0,0 +1,76 @@
+import { expect, test } from 'bun:test';
+import type MediaDbPlugin from 'packages/obsidian/src/main';
+import { ModalHelper, type ModalLifecycle, type ModalSession } from 'packages/obsidian/src/utils/ModalHelper';
+import type { MDBError } from 'packages/obsidian/src/utils/MDBError';
+import { MDBErrorKind } from 'packages/obsidian/src/utils/MDBError';
+import { OutcomeStatus } from 'packages/obsidian/src/utils/result';
+
+class FakeModal implements ModalLifecycle {
+	closeCount = 0;
+
+	open(): void {
+		// Test modal does not need to render.
+	}
+
+	close(): void {
+		this.closeCount += 1;
+	}
+}
+
+function createModalSession(cancelled: () => boolean): ModalSession<undefined, FakeModal> {
+	const modal = new FakeModal();
+
+	return {
+		modal,
+		modalResult: { status: OutcomeStatus.Ok, data: undefined },
+		close: (): void => modal.close(),
+		isCancelled: cancelled,
+	};
+}
+
+function createHelper(): ModalHelper {
+	return new ModalHelper({} as MediaDbPlugin);
+}
+
+test('runModalTask closes the modal after active task success', async () => {
+	const helper = createHelper();
+	const session = createModalSession(() => false);
+
+	const outcome = await helper.runModalTask(session, async () => 'done');
+
+	expect(outcome).toEqual({ status: OutcomeStatus.Ok, data: 'done' });
+	expect(session.modal.closeCount).toBe(1);
+});
+
+test('runModalTask ignores late success after cancellation', async () => {
+	const helper = createHelper();
+	let cancelled = false;
+	const session = createModalSession(() => cancelled);
+
+	const outcome = await helper.runModalTask(session, async () => {
+		cancelled = true;
+		return 'late result';
+	});
+
+	expect(outcome).toEqual({ status: OutcomeStatus.Cancelled });
+	expect(session.modal.closeCount).toBe(0);
+});
+
+test('runModalTask ignores late errors after cancellation', async () => {
+	const helper = createHelper();
+	let cancelled = false;
+	const session = createModalSession(() => cancelled);
+	const fallback: MDBError = { kind: MDBErrorKind.Modal, message: 'Task failed' };
+
+	const outcome = await helper.runModalTask(
+		session,
+		async () => {
+			cancelled = true;
+			throw new Error('Late failure');
+		},
+		fallback,
+	);
+
+	expect(outcome).toEqual({ status: OutcomeStatus.Cancelled });
+	expect(session.modal.closeCount).toBe(0);
+});

tests/placeholder.test.ts

@@ -0,0 +1,5 @@
+import { test, expect } from 'bun:test';
+
+test('placeholder test', () => {
+	expect(true).toBe(true);
+});

tests/setup.ts

@@ -0,0 +1,37 @@
+import { mock } from 'bun:test';
+
+mock.module('obsidian', () => ({
+	AbstractInputSuggest: class {},
+	Component: class {
+		load(): void {}
+		unload(): void {}
+	},
+	DropdownComponent: class {},
+	MarkdownRenderer: { render: async (): Promise<void> => {} },
+	MarkdownView: class {},
+	Modal: class {
+		app: unknown;
+
+		constructor(app: unknown) {
+			this.app = app;
+		}
+
+		open(): void {}
+		close(): void {}
+	},
+	Notice: class {},
+	normalizePath: (path: string): string => path,
+	moment: Object.assign((value?: unknown): unknown => value, { locale: (): void => {} }),
+	parseYaml: (): unknown => ({}),
+	Plugin: class {},
+	PluginSettingTab: class {},
+	requestUrl: async (): Promise<unknown> => ({}),
+	SecretComponent: class {},
+	Setting: class {},
+	SettingGroup: class {},
+	stringifyYaml: (value: unknown): string => String(value),
+	TFile: class {},
+	TFolder: class {},
+	TextComponent: class {},
+	ToggleComponent: class {},
+}));

tests/tsconfig.json

@@ -0,0 +1,11 @@
+{
+	"extends": "../tsconfig.json",
+	"compilerOptions": {
+		"paths": {
+			"packages/*": ["../packages/*"],
+			"tests/*": ["./*"]
+		},
+		"types": ["vite/client", "bun-types"]
+	},
+	"include": ["**/*.ts"]
+}