diff --git a/src/api/apis/MusicBrainzAPI.ts b/src/api/apis/MusicBrainzAPI.ts index b567560..c512886 100644 --- a/src/api/apis/MusicBrainzAPI.ts +++ b/src/api/apis/MusicBrainzAPI.ts @@ -3,7 +3,7 @@ import type MediaDbPlugin from '../../main'; import type { MediaTypeModel } from '../../models/MediaTypeModel'; import { MusicReleaseModel } from '../../models/MusicReleaseModel'; import { MediaType } from '../../utils/MediaType'; -import { contactEmail, mediaDbVersion, pluginName } from '../../utils/Utils'; +import { contactEmail, extractTracksFromMedia, mediaDbVersion, pluginName } from '../../utils/Utils'; import { APIModel } from '../APIModel'; // sadly no open api schema available @@ -136,19 +136,44 @@ export class MusicBrainzAPI extends APIModel { async getById(id: string): Promise { console.log(`MDB | api "${this.apiName}" queried by ID`); - const searchUrl = `https://musicbrainz.org/ws/2/release-group/${encodeURIComponent(id)}?inc=releases+artists+tags+ratings+genres&fmt=json`; - const fetchData = await requestUrl({ - url: searchUrl, + // Fetch release group + const groupUrl = `https://musicbrainz.org/ws/2/release-group/${encodeURIComponent(id)}?inc=releases+artists+tags+ratings+genres&fmt=json`; + const groupResponse = await requestUrl({ + url: groupUrl, headers: { 'User-Agent': `${pluginName}/${mediaDbVersion} (${contactEmail})`, }, }); - if (fetchData.status !== 200) { - throw Error(`MDB | Received status code ${fetchData.status} from ${this.apiName}.`); + if (groupResponse.status !== 200) { + throw Error(`MDB | Received status code ${groupResponse.status} from ${this.apiName}.`); } - const result = (await fetchData.json) as IdResponse; + const result = (await groupResponse.json) as IdResponse; + + // Get ID of the first release + const firstRelease = result.releases?.[0]; + if (!firstRelease) { + throw Error('MDB | No releases found in release group.'); + } + + // Fetch recordings for the first release + const releaseUrl = `https://musicbrainz.org/ws/2/release/${firstRelease.id}?inc=recordings+artists&fmt=json`; + console.log(`MDB | Fetching release recordings from: ${releaseUrl}`); + + const releaseResponse = await requestUrl({ + url: releaseUrl, + headers: { + 'User-Agent': `${pluginName}/${mediaDbVersion} (${contactEmail})`, + }, + }); + + if (releaseResponse.status !== 200) { + throw Error(`MDB | Received status code ${releaseResponse.status} from ${this.apiName}.`); + } + + const releaseData = await releaseResponse.json; + const tracks = extractTracksFromMedia(releaseData.media); return new MusicReleaseModel({ type: 'musicRelease', @@ -164,6 +189,7 @@ export class MusicBrainzAPI extends APIModel { artists: result['artist-credit'].map(a => a.name), genres: result.genres.map(g => g.name), subType: result['primary-type'], + tracks: tracks, rating: result.rating.value * 2, userData: { diff --git a/src/models/MusicReleaseModel.ts b/src/models/MusicReleaseModel.ts index 900f233..456a6dc 100644 --- a/src/models/MusicReleaseModel.ts +++ b/src/models/MusicReleaseModel.ts @@ -11,6 +11,12 @@ export class MusicReleaseModel extends MediaTypeModel { image: string; rating: number; releaseDate: string; + tracks: { + number: number; + title: string; + duration: string; + featuredArtists: string[]; + }[]; userData: { personalRating: number; @@ -36,6 +42,7 @@ export class MusicReleaseModel extends MediaTypeModel { } this.type = this.getMediaType(); + this.tracks = obj.tracks ?? []; } getTags(): string[] { diff --git a/src/utils/Utils.ts b/src/utils/Utils.ts index eb4bbaa..aa9786d 100644 --- a/src/utils/Utils.ts +++ b/src/utils/Utils.ts @@ -296,3 +296,25 @@ export async function obsidianFetch(input: Request): Promise { text: async () => res.text, } as Response; } +export function extractTracksFromMedia(media: any[]): { + number: number; + title: string; + duration: string; + featuredArtists: string[]; +}[] { + if (!media || media.length === 0 || !media[0].tracks) return []; + + return media[0].tracks.map((track: any, index: number) => { + const title = track.title || track.recording?.title || 'Unknown Title'; + const rawLength = track.length || track.recording?.length; + const duration = rawLength ? new Date(rawLength).toISOString().substr(14, 5) : 'unknown'; + const featuredArtists = track['artist-credit']?.map((ac: { name: string }) => ac.name) ?? []; + + return { + number: index + 1, + title, + duration, + featuredArtists, + }; + }); +}