From db444c83f5154a3e46c4a2f0a3e4eaad9979f720 Mon Sep 17 00:00:00 2001
From: Moritz Jung <m.projects.code@gmail.com>
Date: Tue, 20 May 2025 12:11:35 +0200
Subject: [PATCH] refactor image download into method

---
 src/main.ts | 61 +++++++++++++++++++++++++++++++----------------------
 1 file changed, 36 insertions(+), 25 deletions(-)

diff --git a/src/main.ts b/src/main.ts
index 781ee1f..97344f1 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -316,31 +316,8 @@ export default class MediaDbPlugin extends Plugin {
 
 			options.openNote = this.settings.openNoteInNewTab;
 
-			if (mediaTypeModel.image && typeof mediaTypeModel.image === 'string' && mediaTypeModel.image.startsWith('http')) {
-				if (this.settings.imageDownload) {
-					try {
-						const imageurl = mediaTypeModel.image;
-						const imageext = imageurl.split('.').pop()?.split(/\#|\?/)[0] || 'jpg';
-						const imagefileName = `${replaceIllegalFileNameCharactersInString(`${mediaTypeModel.type}_${mediaTypeModel.title} (${mediaTypeModel.year})`)}.${imageext}`;
-						const imagepath = normalizePath(`${this.settings.imageFolder}/${imagefileName}`);
-
-						if (!this.app.vault.getAbstractFileByPath(this.settings.imageFolder)) {
-							await this.app.vault.createFolder(this.settings.imageFolder);
-						}
-
-						if (!this.app.vault.getAbstractFileByPath(imagepath)) {
-							const response = await requestUrl({ url: imageurl, method: 'GET' });
-							await this.app.vault.createBinary(imagepath, response.arrayBuffer);
-						}
-
-						// Update model to use local image path
-						mediaTypeModel.image = `[[${imagepath}]]`;
-					} catch (e) {
-						console.warn('MDB | Failed to download image:', e);
-					}
-				} else {
-					mediaTypeModel.image = mediaTypeModel.image;
-				}
+			if (this.settings.imageDownload) {
+				await this.downloadImageForMediaModel(mediaTypeModel);
 			}
 
 			const fileContent = await this.generateMediaDbNoteContents(mediaTypeModel, options);
@@ -360,6 +337,40 @@ export default class MediaDbPlugin extends Plugin {
 		}
 	}
 
+	/**
+	 * Tries to download the image for a media model.
+	 * 
+	 * @param mediaTypeModel 
+	 * @returns true if the image was downloaded, false otherwise
+	 */
+	private async downloadImageForMediaModel(mediaTypeModel: MediaTypeModel): Promise<boolean> {
+		if (mediaTypeModel.image && typeof mediaTypeModel.image === 'string' && mediaTypeModel.image.startsWith('http')) {
+			try {
+				const imageUrl = mediaTypeModel.image;
+				const imageExt = imageUrl.split('.').pop()?.split(/\#|\?/)[0] || 'jpg';
+				const imageFileName = `${replaceIllegalFileNameCharactersInString(`${mediaTypeModel.type}_${mediaTypeModel.title} (${mediaTypeModel.year})`)}.${imageExt}`;
+				const imagePath = normalizePath(`${this.settings.imageFolder}/${imageFileName}`);
+
+				if (!this.app.vault.getAbstractFileByPath(this.settings.imageFolder)) {
+					await this.app.vault.createFolder(this.settings.imageFolder);
+				}
+
+				if (!this.app.vault.getAbstractFileByPath(imagePath)) {
+					const response = await requestUrl({ url: imageUrl, method: 'GET' });
+					await this.app.vault.createBinary(imagePath, response.arrayBuffer);
+				}
+
+				// Update model to use local image path
+				mediaTypeModel.image = `[[${imagePath}]]`;
+				return true;
+			} catch (e) {
+				console.warn('MDB | Failed to download image:', e);
+			}
+		}
+
+		return false;
+	}
+
 	generateMediaDbNoteFrontmatterPreview(mediaTypeModel: MediaTypeModel): string {
 		const fileMetadata = this.modelPropertyMapper.convertObject(mediaTypeModel.toMetaDataObject());
 		return stringifyYaml(fileMetadata);