From f176a12d6f4ff90b338118c64b0e112850e115a3 Mon Sep 17 00:00:00 2001
From: ltctceplrm <14954927+ltctceplrm@users.noreply.github.com>
Date: Sun, 21 Jun 2026 22:00:13 +0200
Subject: [PATCH] Applied review suggestions

---
 packages/obsidian/src/main.ts              | 12 ++++--------
 packages/obsidian/src/settings/Settings.ts |  4 ++++
 packages/obsidian/src/styles.css           | 10 +++++-----
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/packages/obsidian/src/main.ts b/packages/obsidian/src/main.ts
index 8dbb8dd..13c1127 100644
--- a/packages/obsidian/src/main.ts
+++ b/packages/obsidian/src/main.ts
@@ -33,8 +33,6 @@ import { MEDIA_TYPES } from 'packages/obsidian/src/utils/MediaTypeManager';
 import { ModalHelper } from 'packages/obsidian/src/utils/ModalHelper';
 import { unCamelCase } from 'packages/obsidian/src/utils/Utils';
 
-const LEGACY_API_KEYS = ['OMDbKey', 'TMDBKey', 'MobyGamesKey', 'GiantBombKey', 'ComicVineKey', 'BoardgameGeekKey'] as const;
-
 export default class MediaDbPlugin extends Plugin {
 	declare settings: MediaDbPluginSettings;
 	apiManager!: APIManager;
@@ -173,14 +171,14 @@ export default class MediaDbPlugin extends Plugin {
 	}
 
 	private getLegacyApiKeyEntries(diskSettings: Record<string, unknown>): LegacyApiKeyEntry[] {
-		return LEGACY_API_KEYS.filter(key => typeof diskSettings[key] === 'string' && diskSettings[key].length > 0).map(key => ({
+		return this.settings.LegacyApiKeys.filter(key => typeof diskSettings[key] === 'string' && diskSettings[key].length > 0).map(key => ({
 			key,
 			value: diskSettings[key] as string,
 		}));
 	}
 
 	private removeLegacyApiKeys(settings: Record<string, unknown>): void {
-		for (const key of LEGACY_API_KEYS) {
+		for (const key of this.settings.LegacyApiKeys) {
 			delete settings[key];
 		}
 	}
@@ -202,10 +200,8 @@ export default class MediaDbPlugin extends Plugin {
 			this.app.workspace.onLayoutReady((): void => {
 				window.setTimeout((): void => {
 					new LegacyApiKeysModal(this.app, legacyEntries, (): void => {
-						void (async (): Promise<void> => {
-							this.removeLegacyApiKeys(this.settings as unknown as Record<string, unknown>);
-							await this.saveSettings();
-						})();
+						this.removeLegacyApiKeys(this.settings as unknown as Record<string, unknown>);
+						void this.saveSettings();
 					}).open();
 				}, 0);
 			});
diff --git a/packages/obsidian/src/settings/Settings.ts b/packages/obsidian/src/settings/Settings.ts
index 113a115..02bcb0a 100644
--- a/packages/obsidian/src/settings/Settings.ts
+++ b/packages/obsidian/src/settings/Settings.ts
@@ -58,6 +58,8 @@ export interface MediaDbPluginSettings {
 	ComicVineKeyId: string;
 	BoardgameGeekKeyId: string;
 
+	LegacyApiKeys: readonly ['OMDbKey', 'TMDBKey', 'MobyGamesKey', 'GiantBombKey', 'ComicVineKey', 'BoardgameGeekKey'];
+
 	sfwFilter: boolean;
 	templates: boolean;
 	customDateFormat: string;
@@ -317,6 +319,8 @@ const DEFAULT_SETTINGS: MediaDbPluginSettings = {
 	ComicVineKeyId: '',
 	BoardgameGeekKeyId: '',
 
+	LegacyApiKeys: ['OMDbKey', 'TMDBKey', 'MobyGamesKey', 'GiantBombKey', 'ComicVineKey', 'BoardgameGeekKey'],
+
 	sfwFilter: true,
 	templates: true,
 	customDateFormat: 'L',
diff --git a/packages/obsidian/src/styles.css b/packages/obsidian/src/styles.css
index a2a83b1..0219ad8 100644
--- a/packages/obsidian/src/styles.css
+++ b/packages/obsidian/src/styles.css
@@ -307,7 +307,7 @@ small.media-db-plugin-list-text {
 .media-db-plugin-legacy-keys-wrapper {
 	display: flex;
 	flex-direction: column;
-	gap: 0.75rem;
+	gap: var(--size-4-3);
 	width: 100%;
 	max-width: 100%;
 }
@@ -315,11 +315,11 @@ small.media-db-plugin-list-text {
 .media-db-plugin-legacy-keys-textarea {
 	width: 100%;
 	max-width: 100%;
-	min-height: 100px;
-	min-width: 500px;
+	min-height: var(--size-4-5);
+	min-width: var(--size-4-7);
 	box-sizing: border-box;
 	resize: vertical;
-	padding: 0.75rem;
+	padding: var(--size-4-3);
 	border-radius: var(--radius-s);
 	border: 1px solid var(--background-modifier-border);
 	background: var(--background-primary);
@@ -330,5 +330,5 @@ small.media-db-plugin-list-text {
 	white-space: pre;
 }
 .media-db-plugin-hidden {
-	display: none !important;
+	display: none;
 }