afiqzudinhadi/zmk
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

refactor: use low priority workqueue for underglow and battery reporting

Browse source 
Blocking operations on the high priority system workqueue may result in
deadlocks, particularly when Bluetooth is in use.
This commit is contained in:
Xudong Zheng 2023-07-17 17:16:04 -04:00 • committed by Pete Johanson
parent f743d57ff1
commit 9a963abfc8
6 changed files with 44 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/src/battery.c
View file

@ -18,6 +18,7 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
#include <zmk/event_manager.h>
#include <zmk/battery.h>
#include <zmk/events/battery_state_changed.h>
#include <zmk/workqueue.h>
static uint8_t last_state_of_charge = 0;
@ -77,7 +78,9 @@ static void zmk_battery_work(struct k_work *work) {
K_WORK_DEFINE(battery_work, zmk_battery_work);
static void zmk_battery_timer(struct k_timer *timer) { k_work_submit(&battery_work); }
static void zmk_battery_timer(struct k_timer *timer) {
k_work_submit_to_queue(zmk_workqueue_lowprio_work_q(), &battery_work);
}
K_TIMER_DEFINE(battery_timer, zmk_battery_timer, NULL);
@ -97,14 +100,7 @@ static int zmk_battery_init(const struct device *_arg) {
return -ENODEV;
}
int rc = zmk_battery_update(battery);
if (rc != 0) {
LOG_DBG("Failed to update battery value: %d.", rc);
return rc;
}
k_timer_start(&battery_timer, K_MINUTES(1), K_SECONDS(CONFIG_ZMK_BATTERY_REPORT_INTERVAL));
k_timer_start(&battery_timer, K_NO_WAIT, K_SECONDS(CONFIG_ZMK_BATTERY_REPORT_INTERVAL));
return 0;
}