afiqzudinhadi/zmk
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

style(hold-tap)!: Write hold-tap params with dashes

Browse source 
tapping_term_ms -> tapping-term-ms
quick_tap_ms -> quick-tap-ms

The old style works, although it's deprecated.
This commit is contained in:
Okke Formsma 2021-02-06 21:47:21 +01:00 • committed by Pete Johanson
parent 2af794eed3
commit af9d6e9b05
12 changed files with 25 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/boards/shields/qaz/qaz.keymap
View file

@ -18,7 +18,7 @@
compatible = "zmk,behavior-hold-tap";
label = "homerow mods";
#binding-cells = <2>;
tapping_term_ms = <225>;
tapping-term-ms = <225>;
flavor = "tap-preferred";
bindings = <&kp>, <&kp>;
};

2
app/boards/shields/tg4x/tg4x.keymap
View file

@ -14,7 +14,7 @@
compatible = "zmk,behavior-hold-tap";
label = "Hold Tap";
#binding-cells = <2>;
tapping_term_ms = <200>;
tapping-term-ms = <200>;
flavor = "tap-preferred";
bindings = <&kp>, <&kp>;
};

2
app/dts/behaviors/layer_tap.dtsi
View file

@ -11,7 +11,7 @@
label = "LAYER_TAP";
#binding-cells = <2>;
flavor = "tap-preferred";
tapping_term_ms = <200>;
tapping-term-ms = <200>;
bindings = <&mo>, <&kp>;
};
};

2
app/dts/behaviors/mod_tap.dtsi
View file

@ -11,7 +11,7 @@
label = "MOD_TAP";
#binding-cells = <2>;
flavor = "hold-preferred";
tapping_term_ms = <200>;
tapping-term-ms = <200>;
bindings = <&kp>, <&kp>;
};
};

8
app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml
View file

@ -11,11 +11,15 @@ properties:
bindings:
type: phandles
required: true
tapping_term_ms:
tapping-term-ms:
type: int
quick_tap_ms:
tapping_term_ms: # deprecated
type: int
quick-tap-ms:
type: int
default: -1
quick_tap_ms: # deprecated
type: int
flavor:
type: string
required: false

1
app/src/behaviors/behavior_hold_tap.c
View file

@ -47,7 +47,6 @@ struct behavior_hold_tap_config {
// this data is specific for each hold-tap
struct active_hold_tap {
int32_t position;
// todo: move these params into the config->behaviors->tap and
uint32_t param_hold;
uint32_t param_tap;
int64_t timestamp;

4
app/tests/hold-tap/balanced/behavior_keymap.dtsi
View file

@ -9,8 +9,8 @@
label = "HOLD_TAP_BALANCED";
#binding-cells = <2>;
flavor = "balanced";
tapping_term_ms = <300>;
quick_tap_ms = <200>;
tapping-term-ms = <300>;
quick-tap-ms = <200>;
bindings = <&kp>, <&kp>;
};
};

2
app/tests/hold-tap/balanced/many-nested/native_posix.keymap
View file

@ -9,7 +9,7 @@
label = "HOLD_TAP_BALANCED";
#binding-cells = <2>;
flavor = "balanced";
tapping_term_ms = <300>;
tapping-term-ms = <300>;
bindings = <&kp>, <&kp>;
};
};

4
app/tests/hold-tap/hold-preferred/behavior_keymap.dtsi
View file

@ -11,8 +11,8 @@
label = "hold_hold_tap";
#binding-cells = <2>;
flavor = "hold-preferred";
tapping_term_ms = <300>;
quick_tap_ms = <200>;
tapping-term-ms = <300>;
quick-tap-ms = <200>;
bindings = <&kp>, <&kp>;
};
};

4
app/tests/hold-tap/tap-preferred/behavior_keymap.dtsi
View file

@ -9,8 +9,8 @@
label = "MOD_TAP";
#binding-cells = <2>;
flavor = "tap-preferred";
tapping_term_ms = <300>;
quick_tap_ms = <200>;
tapping-term-ms = <300>;
quick-tap-ms = <200>;
bindings = <&kp>, <&kp>;
};
};