afiqzudinhadi/obsidian-media-db-sync
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Applied review suggestions

Browse source
This commit is contained in:
ltctceplrm 2026-06-21 22:00:13 +02:00
parent e1ab585103
commit f176a12d6f
3 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/obsidian/src/main.ts
View file

@ -33,8 +33,6 @@ import { MEDIA_TYPES } from 'packages/obsidian/src/utils/MediaTypeManager';
import { ModalHelper } from 'packages/obsidian/src/utils/ModalHelper';
import { unCamelCase } from 'packages/obsidian/src/utils/Utils';
const LEGACY_API_KEYS = ['OMDbKey', 'TMDBKey', 'MobyGamesKey', 'GiantBombKey', 'ComicVineKey', 'BoardgameGeekKey'] as const;
export default class MediaDbPlugin extends Plugin {
declare settings: MediaDbPluginSettings;
apiManager!: APIManager;
@ -173,14 +171,14 @@ export default class MediaDbPlugin extends Plugin {
}
private getLegacyApiKeyEntries(diskSettings: Record<string, unknown>): LegacyApiKeyEntry[] {
return LEGACY_API_KEYS.filter(key => typeof diskSettings[key] === 'string' && diskSettings[key].length > 0).map(key => ({
return this.settings.LegacyApiKeys.filter(key => typeof diskSettings[key] === 'string' && diskSettings[key].length > 0).map(key => ({
key,
value: diskSettings[key] as string,
}));
}
private removeLegacyApiKeys(settings: Record<string, unknown>): void {
for (const key of LEGACY_API_KEYS) {
for (const key of this.settings.LegacyApiKeys) {
delete settings[key];
}
}
@ -202,10 +200,8 @@ export default class MediaDbPlugin extends Plugin {
this.app.workspace.onLayoutReady((): void => {
window.setTimeout((): void => {
new LegacyApiKeysModal(this.app, legacyEntries, (): void => {
void (async (): Promise<void> => {
this.removeLegacyApiKeys(this.settings as unknown as Record<string, unknown>);
await this.saveSettings();
})();
this.removeLegacyApiKeys(this.settings as unknown as Record<string, unknown>);
void this.saveSettings();
}).open();
}, 0);
});